View source for Module talk:Pagetype

== Misleading message about redirect ==
{{moved from|Template talk:Edit protected|[[User:Jackmcbarn|Jackmcbarn]] ([[User talk:Jackmcbarn|talk]]) 19:16, 3 April 2014 (UTC)}}
If you put {{tlx|Edit protected|MediaWiki talk:Spam-blacklist/log}} on [[MediaWiki talk:Spam-blacklist]], the box begins with "It is requested that an edit be made to the fully protected redirect at MediaWiki talk:Spam-blacklist/log.". Why "redirect", when [[MediaWiki talk:Spam-blacklist/log]] isn't? See {{oldid|MediaWiki talk:Spam-blacklist|602617506#Full_log|this permalink}}. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] ([[User talk:Redrose64|talk]]) 18:54, 3 April 2014 (UTC)
:{{ping|Mr. Stradivarius}} The issue is that when p._main{page='MediaWiki talk:Spam-blacklist/log'} is called, checkRedirects instead checks to see if MediaWiki:Spam-blacklist/log is a redirect (lines 208-211). I'm not sure what the logic behind doing that that way is. Thoughts? [[User:Jackmcbarn|Jackmcbarn]] ([[User talk:Jackmcbarn|talk]]) 19:16, 3 April 2014 (UTC)
::Yep, that's a bug in the module. It should use the current page rather than the subject page if talk pages are allowed, but at the moment it only checks args.talk, not args.defaultns. I'll have a think about how best to fix this. (Also, your ping didn't work - not sure why.) — '''''[[User:Mr. Stradivarius|<span style="color: #194D00; font-family: Palatino, Times, serif">Mr. Stradivarius</span>]]''''' <sup>[[User talk:Mr. Stradivarius|♪ talk ♪]]</sup> 04:12, 4 April 2014 (UTC)
:::Now fixed. I also uncovered a nasty bug that was introduced by the recent changes to [[Module:Namespace detect]] - this module was trying to use the # operator with the mappings table, which didn't work after it was switched to load using mw.loadData. I also split out the config data to [[Module:Pagetype/config]], loaded using mw.loadData. And I made some beautification fixes too. — '''''[[User:Mr. Stradivarius|<span style="color: #194D00; font-family: Palatino, Times, serif">Mr. Stradivarius</span>]]''''' <sup>[[User talk:Mr. Stradivarius|♪ talk ♪]]</sup> 06:01, 4 April 2014 (UTC)
:::I didn't get a ping either. It might be because it was a page creation? --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] ([[User talk:Redrose64|talk]]) 10:18, 4 April 2014 (UTC)
::::{{ping|Mr. Stradivarius}} Broken in the opposite way now. [{{fullurl:Module talk:Message box|oldid=602879313#Protected_edit_request_on_5_April_2014}}] says talk page instead of module. [[User:Jackmcbarn|Jackmcbarn]] ([[User talk:Jackmcbarn|talk]]) 16:05, 5 April 2014 (UTC)
:::::Bleh. That was a bug I introduced to [[Module:Namespace detect]] this morning trying to fix an unrelated issue. That's now fixed as well. And with that, I think I shall call it a night. If you notice other similar problems, purging should fix it. — '''''[[User:Mr. Stradivarius|<span style="color: #194D00; font-family: Palatino, Times, serif">Mr. Stradivarius</span>]]''''' <sup>[[User talk:Mr. Stradivarius|♪ talk ♪]]</sup> 17:13, 5 April 2014 (UTC)

== Drafts ==

I don't think this module identifies pages in the draft namespace. Please could this be added? &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 11:40, 3 October 2014 (UTC)

:You could either use <nowiki>{{pagetype|draft=true}}</nowiki> or you could edit the cfg.defaultNamespaces section of [[Module:Pagetype/config]]. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 11:56, 3 October 2014 (UTC)
::{{ping|MSGJ}} Drafts are detected fine - they are one of the extended namespaces. See [[Module:Pagetype#Default namespace sets]] for a quick look at what is in what set. And if you think drafts should be in the default set instead of just the extended set, we can make the change in the module config, as WOSlinker said. (We should probably get consensus for that first, though.) — '''''[[User:Mr. Stradivarius|<span style="color: #194D00; font-family: Palatino, Times, serif">Mr. Stradivarius</span>]]''''' <sup>[[User talk:Mr. Stradivarius|♪ talk ♪]]</sup> 13:13, 3 October 2014 (UTC)
:::Yes well, perhaps "draft" should be in that set. <s>Also I'm surprised that "file" is not there.</s> &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 13:51, 3 October 2014 (UTC)
:::Hmm I see "file" is there, but not in the "media" row so I'm a bit confused by that. &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 13:53, 3 October 2014 (UTC)
::::{{ping|MSGJ}} That's because when you click a link to a media namespace page, you're not going to a wiki page, but you're viewing the file directly. For example: [[Media:Example.svg]]. — '''''[[User:Mr. Stradivarius|<span style="color: #194D00; font-family: Palatino, Times, serif">Mr. Stradivarius</span>]]''''' <sup>[[User talk:Mr. Stradivarius|♪ talk ♪]]</sup> 14:00, 3 October 2014 (UTC)
:::::Interesting, I didn't know that! In the meantime I've used {{para|draft|yes}} on [[Template:Importance mask]] so it works as intended. Cheers all &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 11:29, 4 October 2014 (UTC)

== Protected edit request on 28 September 2015 ==

{{edit fully-protected|Module:Pagetype|answered=yes}}
<!-- Begin request -->

Add the Gadget and Gadget definition namespaces and make the page type the same name, but with a lowercase "G".<!-- This will mean that if a speedy deletion template is placed on a page in one of those namespaces, then the page will say "This gadget may meet Wikipedia's criteria for speedy deletion" or "This gadget definition may meet Wikipedia's criteria for speedy deletion". -->
<!-- End request -->
[[User:GeoffreyT2000|GeoffreyT2000]] ([[User talk:GeoffreyT2000|talk]]) 02:50, 28 September 2015 (UTC)
:[[File:Yes check.svg|20px|link=]] '''Done'''<!-- Template:EP --> — '''''[[User:Mr. Stradivarius|<span style="color: #194D00; font-family: Palatino, Times, serif">Mr.&nbsp;Stradivarius</span>]]''''' <sup>[[User talk:Mr. Stradivarius|♪&nbsp;talk&nbsp;♪]]</sup> 03:41, 28 September 2015 (UTC)